Open
Conversation
Author
|
Whoops, noticed something, converting to a draft temporarily. |
Author
|
Fixed, ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Markus!
I found your library while searching for OPUS bindings for Haskell. Your encoder has been really useful.
As I see it, the code only has an Encoder, but I'd love to decode some OPUS audio as well. So here's a pull request!
Changes in this PR
Codec.Audio.Opus.Decoder, which mirrors the Encoder variant for the most part, but also all specs in the OPUS API PDFCodec.Audio.Opus.Decoder.Conduit, which mirrors the Encoder variant closely.Decoder tests
The tests require
opus_compareexecutable in the project root (which can be obtained by compiling this file), and the new opus test vectors (https://opus-codec.org/static/testvectors/opus_testvectors-rfc8251.tar.gz), but once those are in place, passes properly:I would've loved to add similar tests for the Encoder, but the original run_vectors.sh only had decoder testing so I haven't pursued further.
I hope you can take a look/review it, and hopefully merge it in!